Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD][Quantization] Add TritonScaledMMLinearKernel since int8 is broken for AMD #12282

Merged

Conversation

rasmith
Copy link
Contributor

@rasmith rasmith commented Jan 21, 2025

We aren't able to run int8 models anymore, it's completely broken. This because there is no TritonScaledMMLinearKernel class.

I added in TritonScaledMMLinearKernel. Since there is no Triton kernel to handle asymmetric int8 quantization, the new TritonScaledMMLinearKernel checks for this case and returns a failure.

I tested and everything seems to work.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the disruption and thanks for the fix. Could you add an int8 test to the AMD runner to make sure this doesn't regress in the future?

@rasmith
Copy link
Contributor Author

rasmith commented Jan 21, 2025

Sorry for the disruption and thanks for the fix. Could you add an int8 test to the AMD runner to make sure this doesn't regress in the future?

@mgoin Where is the AMD runner?

@mgoin
Copy link
Member

mgoin commented Jan 21, 2025

I'm afk right now but you can look at the tests that have mirror hardware amd, each of these will run on the amd runner

https://github.com/vllm-project/vllm/blob/main/.buildkite/test-pipeline.yaml#L93

@rasmith rasmith requested a review from WoosukKwon as a code owner January 22, 2025 18:32
Signed-off-by: Randall Smith <[email protected]>
Signed-off-by: Randall Smith <[email protected]>
@rasmith
Copy link
Contributor Author

rasmith commented Jan 22, 2025

Sorry for the disruption and thanks for the fix. Could you add an int8 test to the AMD runner to make sure this doesn't regress in the future?

@mgoin I put a test in test_triton_scaled_mm.py to just load a small model and test it. It only runs when current platform is ROCm.

@mgoin
Copy link
Member

mgoin commented Jan 22, 2025

Thank you, looks good!

@mgoin mgoin added quantization ready ONLY add when PR is ready to merge/full CI is needed labels Jan 22, 2025
@mgoin mgoin enabled auto-merge (squash) January 22, 2025 20:50
@mgoin mgoin merged commit 68c4421 into vllm-project:main Jan 23, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quantization ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants